Re: git bisect view's use of DISPLAY environment variable in Cygwin

From: Hannu Koivisto <azure@iki.fi>
Date: Oct 28, 2008, 17:51 UTC
Message-ID: <83skqg1uc9.fsf@kalahari.s2.org>
In-Reply-To: <c07716ae0810281015s47741fdqec4c3bed3313bb6a@mail.gmail.com>

"Christian Couder" <christian.couder@gmail.com> writes:

Show 12 quoted lines

> Hi,
>
> On Tue, Oct 28, 2008 at 5:28 PM, Hannu Koivisto <azure@iki.fi> wrote:
>> Greetings,
>>
>> git bisect view uses gitk if DISPLAY environment variable is set
>> and git log otherwise.  Since gitk doesn't require X server in
>> Cygwin, that seems like a bit questionable condition in that
>> environment.
>
> Do you know any environment variable that we could use to detect we
> can use gitk in Cygwin?

I looked around and I believe there is no such variable. I suppose the only case where you cannot use gitk is when the user is logged on using ssh, telnet, psexec or similar (well, unless you use some non-standard Tcl/Tk build which is configured to use X instead of Windows graphics). Then again, I don't think typical Windows programs do any checks for such situations.

So, easy fix: always use gitk unless log is specified. Harder fix: figure out a way to test if the login session is such that graphical applications can be run.

> You can use "git bisect view log" to use "git log" even if DISPLAY is set.

I'd rather not use undocumented functionality ;)

-- 
Hannu