git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] index-pack: never prune base_cache.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 23, 2008, 13:09 UTC
Message-ID
<alpine.DEB.1.00.0807231407040.8986@racer>
In-Reply-To
<20080723125226.GA11679@atjola.homenet>
Hi,
On Wed, 23 Jul 2008, Björn Steinbrink wrote:
Show 10 quoted lines
> On 2008.07.23 14:11:18 +0200, Pierre Habouzit wrote:
> > It may belong to something (stdin) that is consumed.
> 
> Probably thanks to me, babbling about stdin without having a clue what 
> I'm talking about, that rationale is wrong.
> 
> We may not prune base_cache since that object might come from a
> different pack than the one that we are processing. In such a case, we
> would try to restore the data for that object from the pack we're
> processing and fail miserably.
Then the proper fix would be to load the object from that pack again.
> The patch itself should be fine.

No, since it opens the whole issue of memory explosion again, the same issue Shawn's original patch tried to fix.

Ciao, Dscho

P.S.: Could you please, please, please cull the part you are not responding to? This mailing list is read by more than 50 people. If you sum up the time it takes them to realize that that quoted part was irrelevant, I am sure you will end up with a larger number of minutes than it would take you to just delete it.

Thanks.
Previous: Björn SteinbrinkNext: Pierre Habouzit
Message 19 of 24 in “regression in 92392b4”
  1. Pierre HabouzitJul 22, 2008
  2. Johannes SchindelinJul 22, 2008
  3. Shawn O. PearceJul 23, 2008
  4. Johannes SchindelinJul 23, 2008
  5. Pierre HabouzitJul 23, 2008
  6. Johannes SchindelinJul 23, 2008
  7. Pierre HabouzitJul 22, 2008
  8. Björn SteinbrinkJul 23, 2008
  9. Pierre HabouzitJul 23, 2008
  10. Pierre HabouzitJul 23, 2008
  11. Johannes SchindelinJul 23, 2008
  12. Björn SteinbrinkJul 23, 2008
  13. Pierre HabouzitJul 23, 2008
  14. Johannes SchindelinJul 23, 2008
  15. Pierre HabouzitJul 23, 2008
  16. Björn SteinbrinkJul 23, 2008
  17. index-pack: never prune base_cache.Pierre Habouzit, Jul 23, 2008
  18. Björn SteinbrinkJul 23, 2008
  19. Johannes SchindelinJul 23, 2008
  20. Pierre HabouzitJul 23, 2008
  21. Johannes SchindelinJul 23, 2008
  22. Björn SteinbrinkJul 23, 2008
  23. Johannes SchindelinJul 23, 2008
  24. Pierre HabouzitJul 23, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.