Re: [PATCH] index-pack: never prune base_cache.

From: Pierre Habouzit <madcoder@debian.org>
Date: Jul 23, 2008, 13:20 UTC
Message-ID: <20080723132031.GC20614@artemis.madism.org>
In-Reply-To: <alpine.DEB.1.00.0807231407040.8986@racer>

On Wed, Jul 23, 2008 at 01:09:40PM +0000, Johannes Schindelin wrote:

Show 5 quoted lines

> On Wed, 23 Jul 2008, Björn Steinbrink wrote:
> > The patch itself should be fine.
> 
> No, since it opens the whole issue of memory explosion again, the same 
> issue Shawn's original patch tried to fix.

  No it won't. Indeed the issue is with fix_unresolved_deltas that
sometimes put at the root of the chain (in base_cache) something that
comes from our store, not the pack we are writing. Then starts a delta
chain resolution.

  It won't explode in memory at all, we just keep the first data of a
delta chain in memory, that's all. It indeed consumes more memory, but
we talk about *one* single object per delta chain because we're too lazy
to memorize where it comes from. It's probably not much of an explosion.

  We also waste that object even when it's from our own pack. Well, I'd
say "too bad".

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org