Re: regression in 92392b4

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 23, 2008, 00:58 UTC
Message-ID: <alpine.DEB.1.00.0807230152580.8986@racer>
In-Reply-To: <20080723004108.GB14668@spearce.org>

Hi,

On Tue, 22 Jul 2008, Shawn O. Pearce wrote:

Show 10 quoted lines

> Reading above shows we got a "fatal: Out of memory, malloc failed" right 
> before the segfault.  What's odd is we segfaulted after we ran out of 
> memory and should have die'd.
> 
> There's at least two bugs in the above output:
> 
> a) index-pack ran out of memory on a small pull (95 KiB).
> b) fetch segfaulted when index-pack failed.
> 
> And this patch will unfortunately address neither of them.  :-|

Yeah, I thought I had something, but no matter what I tried, I could not find a breakage. Not even valgrind complains.

But as I said: it was just a guess.

Maybe it will be easier to reproduce by patching the code to malloc() everything that is available first, and then continuing.

Ciao, Dscho