git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] builtin-add.c: restructure the code for maintainability

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 21, 2008, 00:56 UTC
Message-ID
<alpine.DEB.1.00.0807201529150.3305@eeepc-johanness>
In-Reply-To
<1216534144-23826-1-git-send-email-gitster@pobox.com>
Hi,
On Sat, 19 Jul 2008, Junio C Hamano wrote:
Show 10 quoted lines
> diff --git a/builtin-add.c b/builtin-add.c
> index bf13aa3..9b2ee8c 100644
> --- a/builtin-add.c
> +++ b/builtin-add.c
> [...]
> +	/*
> +	 * If we are adding new files, we need to scan the working
> +	 * tree to find the ones that match pathspecs; this needs
> +	 * to be done before we read the index.
> +	 */

This comment left me scratching my head. While I do see a breakage when reading the index first, I had the impression that it should not.

I can only imagine that the other users of read_directory() depend on some funny interaction between the index and treat_directory().

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Schindelin
Message 5 of 16 in “builtin-add.c: restructure the code for maintainability”
  1. 1/4 builtin-add.c: restructure the code for maintainabilityJunio C Hamano, Jul 20, 2008
  2. 2/4 git-add --all: add all filesJunio C Hamano, Jul 20, 2008
  3. 3/4 git-add --all: testsJunio C Hamano, Jul 20, 2008
  4. 4/4 git-add --all: documentationJunio C Hamano, Jul 20, 2008
  5. Johannes SchindelinJul 21, 2008
  6. git add: do not add files from a submoduleJohannes Schindelin, Jul 21, 2008
  7. Johannes SchindelinJul 22, 2008
  8. Junio C HamanoJul 23, 2008
  9. Pierre HabouzitJul 23, 2008
  10. Junio C HamanoJul 23, 2008
  11. Pierre HabouzitJul 23, 2008
  12. Johannes SchindelinJul 23, 2008
  13. Pierre HabouzitJul 23, 2008
  14. Junio C HamanoJul 21, 2008
  15. Junio C HamanoJul 21, 2008
  16. Junio C HamanoJul 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.