git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] git add: do not add files from a submodule

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 23, 2008, 06:40 UTC
Message-ID
<7vhcahgl2j.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0807222230490.8986@racer>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Do you plan to apply the split-up builtin-add enhancments you did a few 
> nights ago,...
I have a few updates to that one, I'll be sending them out shortly.

Switching branches between revs that have and do not have submodule at a given path has always been broken. It is not even a "known breakage", which is a word used for something that has a sensible design already is worked out but the implementation does not do so.

If we started the process of diagnosing and fixing these issues earlier, and had plausible code to address the issue already in 'next' before the current -rc cycle started, the topic would have been an obvious candidate for the coming release and I'd further say it would be even worth delaying the release for a few weeks if it takes more time. But I have to say it is too late for 1.6.0 now if we are just noticing and starting the discussion. This comment goes to the issue Pierre raised last night as well.

Nobody prevents us from starting the process to discuss and prepare to put something in 'next' for 1.6.1 cycle now, though.

Previous: Johannes SchindelinNext: Pierre Habouzit
Message 8 of 16 in “builtin-add.c: restructure the code for maintainability”
  1. 1/4 builtin-add.c: restructure the code for maintainabilityJunio C Hamano, Jul 20, 2008
  2. 2/4 git-add --all: add all filesJunio C Hamano, Jul 20, 2008
  3. 3/4 git-add --all: testsJunio C Hamano, Jul 20, 2008
  4. 4/4 git-add --all: documentationJunio C Hamano, Jul 20, 2008
  5. Johannes SchindelinJul 21, 2008
  6. git add: do not add files from a submoduleJohannes Schindelin, Jul 21, 2008
  7. Johannes SchindelinJul 22, 2008
  8. Junio C HamanoJul 23, 2008
  9. Pierre HabouzitJul 23, 2008
  10. Junio C HamanoJul 23, 2008
  11. Pierre HabouzitJul 23, 2008
  12. Johannes SchindelinJul 23, 2008
  13. Pierre HabouzitJul 23, 2008
  14. Junio C HamanoJul 21, 2008
  15. Junio C HamanoJul 21, 2008
  16. Junio C HamanoJul 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.