Re: [PATCH/RFC] git add: do not add files from a submodule

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2008, 18:31 UTC
Message-ID: <7v8wvse9l7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080723081333.GA15243@artemis.madism.org>

Pierre Habouzit <madcoder@debian.org> writes:

Show 15 quoted lines

> On Wed, Jul 23, 2008 at 06:40:20AM +0000, Junio C Hamano wrote:
> ...
>> If we started the process of diagnosing and fixing these issues earlier,
>> and had plausible code to address the issue already in 'next' before the
>> current -rc cycle started, the topic would have been an obvious candidate
>> for the coming release and I'd further say it would be even worth delaying
>> the release for a few weeks if it takes more time.  But I have to say it
>> is too late for 1.6.0 now if we are just noticing and starting the
>> discussion.
>
>   Well given that we now use submodules at work, and that git is
> nowadays somewhere in the top 5 of my most consciously (as opposed to
> the compiler that I rarely call by hand) used software suites (among my
> editor, my MUA, my shell and my tiling WM), I'm very much interested in
> tackling some things about what is (not) done with submodules yet.

Surely the effort is appreciated.

>> This comment goes to the issue Pierre raised last night as well.
>
>   You mean the git checkout issue?

Oh, no; that misuse of parse_opt() that forgot KEEP_DASHDASH one was not what I had in mind. I meant to say that your "switch branches between an old pre-submodule rev and a new one that has a submodule at where a blob or directory used to be" issue with a good explanation material was a good starting point for submodule improvements for the next cycle.

I'd like the release schedule not too heavily based on "per feature", but more time-based.