Re: [PATCH] rerere: Separate libgit and builtin functions

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 9, 2008, 12:03 UTC
Message-ID: <alpine.DEB.1.00.0807091356050.5277@eeepc-johanness>
In-Reply-To: <1215598683-9685-1-git-send-email-s-beyer@gmx.net>

Hi,

On Wed, 9 Jul 2008, Stephan Beyer wrote:

Show 5 quoted lines

>  Makefile                     |    2 +
>  builtin-rerere.c             |  324 +++---------------------------------------
>  builtin-rerere.c => rerere.c |  133 +-----------------
>  rerere.h                     |    9 ++
>  4 files changed, 32 insertions(+), 436 deletions(-)

Heh, that sounds nice!  Deleting way more lines than adding!  :-)

>  copy builtin-rerere.c => rerere.c (66%)

Oh, well :-)

Show 16 quoted lines

> diff --git a/builtin-rerere.c b/rerere.c
> similarity index 66%
> copy from builtin-rerere.c
> copy to rerere.c
> index 85222d9..5c22bed 100644
> --- a/builtin-rerere.c
> +++ b/rerere.c
> @@ -1,18 +1,11 @@
> -#include "builtin.h"
>  #include "cache.h"
>  #include "path-list.h"
> +#include "rerere.h"
>  #include "xdiff/xdiff.h"
>  #include "xdiff-interface.h"
>  
>  #include <time.h>

No longer necessary, is it?

Show 12 quoted lines

> diff --git a/rerere.h b/rerere.h
> new file mode 100644
> index 0000000..35b0fa8
> --- /dev/null
> +++ b/rerere.h
> @@ -0,0 +1,9 @@
> +#ifndef RERERE_H
> +#define RERERE_H
> +
> +#include "path-list.h"
> +
> +extern int setup_rerere(struct path_list *);

Why?

Ah, it is needed for "gc". Maybe this needs documentation, since it cause some minutes of head scratching with yours truly.

Ciao, Dscho