Re: [PATCH] completion: add branch options --contains --merged --no-merged
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 8, 2008, 11:36 UTC
- Message-ID
- <alpine.DEB.1.00.0807081335470.4319@eeepc-johanness>
- In-Reply-To
- <7vprppvt7a.fsf@gitster.siamese.dyndns.org>
Hi,
On Mon, 7 Jul 2008, Junio C Hamano wrote:
Show 24 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes: > > > Eric Raible <raible@gmail.com> wrote: > >> Signed-off-by: Eric Raible <raible@gmail.com> > > > > Trivially-Acked-by: Shawn O. Pearce <spearce@spearce.org> > > > > ;-) > > > > More completion support that probably should go to maint, as the > > functionality in git-branch is in 1.5.6 but we (again) forgot to > > make sure the completion was up-to-date prior to release. > > I am actually getting more worried about completion code getting larger > and larger without its performance impact not being looked at nor > addressed adequately. In my regular working tree: > > $ echo Docu<TAB> > > completes "mentation/" instantly, but: > > $ git log -- Docu<TAB> > > takes about 1.5 to 2 seconds to complete the same.
I noticed that myself, but did not have time to look into it.
It shows two bugs, actually: completions do not care about "--", and completing refs takes way too long.
Ciao, Dscho