Re: [PATCH] completion: add branch options --contains --merged --no-merged
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 8, 2008, 05:30 UTC
- Message-ID
- <7vprppvt7a.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080708044922.GD2542@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> writes:
Show 10 quoted lines
> Eric Raible <raible@gmail.com> wrote: >> Signed-off-by: Eric Raible <raible@gmail.com> > > Trivially-Acked-by: Shawn O. Pearce <spearce@spearce.org> > > ;-) > > More completion support that probably should go to maint, as the > functionality in git-branch is in 1.5.6 but we (again) forgot to > make sure the completion was up-to-date prior to release.
I am actually getting more worried about completion code getting larger and larger without its performance impact not being looked at nor addressed adequately. In my regular working tree:
$ echo Docu<TAB>
completes "mentation/" instantly, but:
$ git log -- Docu<TAB>
takes about 1.5 to 2 seconds to complete the same.