Re: [PATCH] Use perl instead of tac

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 28, 2008, 14:20 UTC
Message-ID: <alpine.DEB.1.00.0804281520220.5399@eeepc-johanness>
In-Reply-To: <E58664C1-86E5-452A-A7CD-2007DD59A75E@silverinsanity.com>

Hi,

On Mon, 28 Apr 2008, Brian Gernhardt wrote:

Show 10 quoted lines

> On Apr 28, 2008, at 9:46 AM, Johannes Schindelin wrote:
> 
> >How about fixing the code to not need tac instead?  We went to great 
> >lengths to introduce the --reverse option to the rev-list command, in 
> >order to avoid tac in the original version of rebase -i.
> 
> Because this is reversing the output of a sub-shell (ll.395-471), not 
> rev-list.  And making the shell code insert commands before the lines 
> the produce it would make the code complex at best.  (And it's not 
> simple code either.)

That's my _point_: the code is way too complex for what it tries to accomplish, namely implement a sane syntax for rebase -i -p.

Ciao, Dscho