Re: [PATCH] Use perl instead of tac

From

JSJörg Sommer <joerg@alea.gnuu.de>

Date

Apr 30, 2008, 09:02 UTC

Message-ID

<20080430090206.GA21826@alea.gnuu.de>

In-Reply-To

<04EB077D-CB35-4253-A9EA-2085890C3639@silverinsanity.com>

Hi Brian,

Brian Gernhardt schrieb am Mon 28. Apr, 15:13 (-0400):

> This loop-reverse-loop construct is _extremely_ ugly, and I'm having  
> problems following it.  None of what this function is doing is  
> immediately obvious.  It's a good candidate for a comment or two.

I write one.

> I also dislike the large lists this is carrying around in shell  
> variables.  If I'm reading it correctly, the tag list could be replaced 
> by invocations of "git describe --exact-match".

Yes. How to get all tags of a commit?

> Now that I think about it, the generation of marks could be done by a  
> second loop over the list.  Notice what commits need to be marked in  
> loop 1, then add the mark commands in loop 2.  Both of these loops would 
> function in the same direction, removing the need for either tac or perl.

You are right.

Thanks for your comments.

Bye, Jörg.

-- 
Damit das Mögliche entsteht, muß immer wieder das Unmögliche versucht
werden.                                       (Hermann Hesse)