Re: [PATCH] Use perl instead of tac

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 28, 2008, 13:46 UTC
Message-ID: <alpine.DEB.1.00.0804281444320.5399@eeepc-johanness>
In-Reply-To: <slrng1be8l.25r.joerg@alea.gnuu.de>

Hi,

On Mon, 28 Apr 2008, Jörg Sommer wrote:

Show 15 quoted lines

> Brian Gernhardt <benji@silverinsanity.com> wrote:
> > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> > index 1751b08..303b754 100755
> > --- a/git-rebase--interactive.sh
> > +++ b/git-rebase--interactive.sh
> > @@ -469,7 +469,7 @@ create_extended_todo_list () {
> >   	test -n "${last_parent:-}" -a "${last_parent:-}" != $SHORTUPSTREAM  
> > && \
> >   		echo reset $last_parent
> >   	) | \
> > -	tac | \
> > +	perl -e 'print reverse <>' | \
> 
> What about using a shell function and a *big* variable or an 
> intermediate file?

How about fixing the code to not need tac instead? We went to great lengths to introduce the --reverse option to the rev-list command, in order to avoid tac in the original version of rebase -i.

Ciao, Dscho