Re: [PATCH 2/2] commit-graph: propagate topo_levels slab to all chain layers
- From
Taylor Blau <ttaylorr@openai.com>
- Date
- Jul 14, 2026, 03:31 UTC
- Message-ID
- <alWtk5eQqS9JTzDr@com-79390>
- In-Reply-To
- <alSCv5I94qjbSucQ@pks.im>
On Mon, Jul 13, 2026 at 08:16:31AM +0200, Patrick Steinhardt wrote:
Show 26 quoted lines
> On Fri, Jul 10, 2026 at 03:14:28PM -0700, Taylor Blau wrote: > > On Tue, Jul 07, 2026 at 04:57:13PM +0200, Kristofer Karlsson wrote: > > > (b) Move topo_levels to struct object_database. Since > > > fill_commit_graph_info() can already reach the odb via > > > g->odb_source->odb, no signature changes are needed. > > > The write side becomes a single assignment: > > > > > > ctx.r->objects->topo_levels = &topo_levels; > > > > > > and cleanup becomes: > > > > > > ctx.r->objects->topo_levels = NULL; > > > > > > No chain walk needed and the diff is fairly small. > > > I am not sure about the semantics of it though -- should the odb > > > have a reference to topo_levels? > > > > This seems to be the most promising approach, though I'd be curious what > > Patrick's thoughts are. The commit-slab API is really a property of the > > object database, but we treat these as a global as I do not recall them > > yet being touched by the ODB refactoring effort. > > I was investigating several times whether we can remove them from global > scope and move them into the object database indeed. The answer is that > it's somewhat complicated because we reuse the slab for multiple > different things, and detangling that has proven to be a bit of a mess.
It's an interesting question, and I think worth discussing, though note that I would also like to ensure that we resolve this in the short-term to prevent any future regression while the pluggable ODB refactor continues on.
Show 11 quoted lines
> The other question here is whether commit graphs really are a property > of the object database itself, or whether they are rather a property of > a given backend. Sure, we can only have a single commit graph at any > point in time, so they feel like they are at the object database level. > But is the current implementation of a commit graph really the best for > all potential backends out there? > > If you take for example a distributed backend to store objects, then you > probably don't want to have a single local commit graph that is stored > in ".git/objects/info". Furthermore, the current format may not even be > the best one to store the cached information, either.
I think I agree here in part, though I think there is some subtlety that is specific to commit-graphs.
If I understand your argument correctly, I think that I am on-board with it if you substitute "commit-graph" with "MIDX" or "reachability bitmaps", as those are optimizations over a specific representation of the object store.
The commit-graph is somewhat of an oddity in that regard. While it is partially an optimization in the representation format, it is also a data-structure which is useful independent of the underlying storage. On the former, I absolutely agree with what you're saying: having a row-oriented layout to optimize commit traversals may not be necessary in a different implementation of the object store which has efficient enough access to the commit objects so as to make the row-oriented layout unnecessary.
However, it is a useful question to ask "what is the generation number of this commit?" independently of whether we store the commit objects themselves in the existing ODB, in a generic blob storage system, or something else entirely.
Thanks, Taylor