Re: [PATCH 2/2] commit-graph: propagate topo_levels slab to all chain layers
- From
Kristofer Karlsson <krka@spotify.com>
- Date
- Jul 7, 2026, 14:02 UTC
- Message-ID
- <CAL71e4P4kM3a80DkyfWXXrCt2o+KKem8iFDM6qgmodRy1aiqLg@mail.gmail.com>
- In-Reply-To
- <ak0D44nhSH/98WYD@nand.local>
On Tue, 7 Jul 2026 at 15:49, Taylor Blau <me@ttaylorr.com> wrote:
Show 13 quoted lines
> > > g = prepare_commit_graph(ctx.r); > > for (struct commit_graph *chain = g; chain; chain = chain->base_graph) > > - g->topo_levels = &topo_levels; > > + chain->topo_levels = &topo_levels; > > > > Looks obviously good. > > I think that there is a more permanent fix, though, which would have not > allowed this bug to evade both its author, and reviewer (me). I *think* > that we may clear up some scoping issues if we removed g->topo_levels > entirely, and instead stored it in the write_commit_graph_ctx struct.
I think that sounds feasible, but it would be a larger change. I wanted to keep this fix minimal and restore the code to match the pre-regression state. I can maybe look into a refactoring as followup (or help review someone elses refactoring?), though I would also be happy just to get that extra 4 seconds back on every fetch for now :)
Thanks, Kristofer