Re: [PATCH 1/2] commit-graph: add trace2 instrumentation for generation DFS
- From
Taylor Blau <ttaylorr@openai.com>
- Date
- Jul 10, 2026, 22:09 UTC
- Message-ID
- <alFthqGQjsowvpEz@com-79390>
- In-Reply-To
- <CAL71e4PuD9D8LRbP3mfxxeMrM+1q--3sCp6oJs=hezdasZUPMw@mail.gmail.com>
On Tue, Jul 07, 2026 at 04:08:36PM +0200, Kristofer Karlsson wrote:
Show 13 quoted lines
> > Instead of writing "# BUG ..." and then an incorrect assertion, I > > would suggest that you write the assertion you expect: > > > > test_trace2_data commit-graph generation-dfs-steps 1 <trace.txt > > > > , but mark the test as "test_expect_failure". > > I started with this actually and then changed my mind in order > to demonstrate exactly how the counter changed, not just that it > changed from failure to success. But I'd be happy to change this > too if needed - it would effectively reduce the second commit to > just the bugfix line and switching from test_expect_failure > to test_expect_success.
Yeah, I think this would be ideal.
Thanks, Taylor