git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/7] git_hash_*() quality-of-life improvements

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 8, 2026, 08:05 UTC
Message-ID
<ak4E4-jmgYFSI75O@pks.im>
In-Reply-To
<20260708035235.GA41491@coredump.intra.peff.net>
On Tue, Jul 07, 2026 at 11:52:35PM -0400, Jeff King wrote:
Show 21 quoted lines
> On Tue, Jul 07, 2026 at 12:55:57AM -0400, Jeff King wrote:
> 
> > This implements the "idempotent git_hash_discard()" discussed in this
> > subthread:
> > 
> >   https://lore.kernel.org/git/20260702080707.GG2029434@coredump.intra.peff.net/
> > 
> > with associated cleanups.
> 
> Here's a v2 addressing the comments so far. Mostly minor changes:
> 
>   - fixed typos noticed by Patrick
> 
>   - dropped extra braces added by coccinelle
> 
>   - dropped a trailing blank line from patch 1 (this gets fixed in a
>     later patch as we add more content after the blank line, but I
>     noticed "git apply" complaining)
> 
>   - a bit more explanation in patch 7 about why we don't support
>     idempotent final() calls

All of these changes look good to me, and the range-diff matches what you describe here. So this series looks good to me, thanks!

Patrick
Previous: Jeff King
Message 35 of 35 in “git_hash_*() quality-of-life improvements”
  1. 0/7 git_hash_*() quality-of-life improvementsJeff King, Jul 7, 2026
  2. 1/7 hash: use git_hash_init() consistentlyJeff King, Jul 7, 2026
  3. Junio C HamanoJul 7, 2026
  4. Jeff KingJul 7, 2026
  5. Junio C HamanoJul 7, 2026
  6. Jeff KingJul 7, 2026
  7. brian m. carlsonJul 7, 2026
  8. Jeff KingJul 8, 2026
  9. 2/7 hash: convert remaining direct function callsJeff King, Jul 7, 2026
  10. Junio C HamanoJul 7, 2026
  11. 3/7 hash: document function pointers and wrappersJeff King, Jul 7, 2026
  12. Patrick SteinhardtJul 7, 2026
  13. Jeff KingJul 7, 2026
  14. 4/7 hash: make git_hash_discard() idempotentJeff King, Jul 7, 2026
  15. Junio C HamanoJul 7, 2026
  16. Jeff KingJul 7, 2026
  17. brian m. carlsonJul 7, 2026
  18. Junio C HamanoJul 7, 2026
  19. 5/7 csum-file: use idempotent git_hash_discard()Jeff King, Jul 7, 2026
  20. 6/7 http: use idempotent git_hash_discard()Jeff King, Jul 7, 2026
  21. Junio C HamanoJul 7, 2026
  22. 7/7 hash: check ctx->active flag in all wrapper functionsJeff King, Jul 7, 2026
  23. Patrick SteinhardtJul 7, 2026
  24. Junio C HamanoJul 7, 2026
  25. Jeff KingJul 7, 2026
  26. Patrick SteinhardtJul 7, 2026
  27. 0/7 git_hash_*() quality-of-life improvementsJeff King, Jul 8, 2026
  28. 1/7 hash: use git_hash_init() consistentlyJeff King, Jul 8, 2026
  29. 2/7 hash: convert remaining direct function callsJeff King, Jul 8, 2026
  30. 3/7 hash: document function pointers and wrappersJeff King, Jul 8, 2026
  31. 4/7 hash: make git_hash_discard() idempotentJeff King, Jul 8, 2026
  32. 5/7 csum-file: use idempotent git_hash_discard()Jeff King, Jul 8, 2026
  33. 6/7 http: use idempotent git_hash_discard()Jeff King, Jul 8, 2026
  34. 7/7 hash: check ctx->active flag in all wrapper functionsJeff King, Jul 8, 2026
  35. Patrick SteinhardtJul 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.