From: Patrick Steinhardt Date: Wed, 08 Jul 2026 08:05:55 GMT Subject: Re: [PATCH v2 0/7] git_hash_*() quality-of-life improvements Message-ID: In-Reply-To: <20260708035235.GA41491@coredump.intra.peff.net> On Tue, Jul 07, 2026 at 11:52:35PM -0400, Jeff King wrote: > On Tue, Jul 07, 2026 at 12:55:57AM -0400, Jeff King wrote: > > > This implements the "idempotent git_hash_discard()" discussed in this > > subthread: > > > > https://lore.kernel.org/git/20260702080707.GG2029434@coredump.intra.peff.net/ > > > > with associated cleanups. > > Here's a v2 addressing the comments so far. Mostly minor changes: > > - fixed typos noticed by Patrick > > - dropped extra braces added by coccinelle > > - dropped a trailing blank line from patch 1 (this gets fixed in a > later patch as we add more content after the blank line, but I > noticed "git apply" complaining) > > - a bit more explanation in patch 7 about why we don't support > idempotent final() calls All of these changes look good to me, and the range-diff matches what you describe here. So this series looks good to me, thanks! Patrick