Re: [PATCH 1/7] hash: use git_hash_init() consistently
- From
Jeff King <peff@peff.net>
- Date
- Jul 8, 2026, 03:54 UTC
- Message-ID
- <20260708035439.GA41684@coredump.intra.peff.net>
- In-Reply-To
- <ak1u25b2pmRAQIxD@fruit.crustytoothpaste.net>
On Tue, Jul 07, 2026 at 09:25:48PM +0000, brian m. carlson wrote:
Show 18 quoted lines
> On 2026-07-07 at 05:01:41, Jeff King wrote: > > We'd like to add more logic to git_hash_init(), but many callers skip it > > and call algop->init_fn() directly. Let's make sure we're consistently > > using the wrapper by adding a coccinelle rule. > > > > Besides the coccinelle file itself, this is a purely mechanical > > conversion based on the patch it generates. There should be no bare > > init_fn() calls left (except for the one in the wrapper). > > For context, the reason `git_hash_init` exists is that our Rust code > needs to initialize a hash context but it treats `const struct > git_hash_algo *` as `const void *` and doesn't have any access to the > contents of the structure. We could fix this with `cbindgen` and > `bindgen`, but haven't done so yet. > > So that's why everybody has been using `init_fn` instead of > `git_hash_init`. Anyway, I have no objections to making this the > standard interface going forward.
Thanks, I remember there being some actual reason but couldn't recall exactly what it was. The use of bare algo->update_fn(), etc, in two spots was what really puzzled me. It's not wrong, but just harder to write than the usual way. ;)
-Peff