Re: [PATCH v4 8/9] hook: warn when hook.<friendly-name>.jobs is set

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 24, 2026, 09:08 UTC
Message-ID: <acJUdkaddmaSeJJb@pks.im>
In-Reply-To: <20260320135311.331463-9-adrian.ratiu@collabora.com>

On Fri, Mar 20, 2026 at 03:53:10PM +0200, Adrian Ratiu wrote:

Show 10 quoted lines

> Issue a warning when the user confuses the hook process and event
> namespaces by setting hook.<friendly-name>.jobs.
> 
> Detect this by checking whether the name carrying .jobs also has
> .command, .event, or .parallel configured.  Extract is_friendly_name()
> as a helper for this check, to be reused by future per-event config
> handling.
> 
> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>

Oh, you already do so. Great :)

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.