git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 00/12] Hash-independent tests (part 3)

From
Derrick Stolee <stolee@gmail.com>
Date
Sep 13, 2018, 17:00 UTC
Message-ID
<abd21e68-ac72-3111-5813-7d47af3d6aa6@gmail.com>
In-Reply-To
<20180913051742.252276-1-sandals@crustytoothpaste.net>
On 9/13/2018 1:17 AM, brian m. carlson wrote:
Show 10 quoted lines
> This is the next in the series of improvements to make tests
> hash-independent.
>
> A range-diff is below.
>
> Changes from v4:
> * Add local statements to the &&-chain.
> * Fix a typo in the local statement.
> * Add a helpful comment about why test_detect_hash is hard-coded to
>    SHA-1.

The range-diff and these changes since v4 are reasonable. I'm happy with the current version.

I'm looking forward to this change getting merged down, as I also want to use 'test_oid rawsz' for the 'git multi-pack-index verify' tests that are currently under review (v2 imminent).

Thanks,
-Stolee
Previous: brian m. carlson
Message 15 of 15 in “Hash-independent tests (part 3)”
  1. 00/12 Hash-independent tests (part 3)brian m. carlson, Sep 13, 2018
  2. 01/12 t: add test functions to translate hash-related valuesbrian m. carlson, Sep 13, 2018
  3. 02/12 t0000: use hash translation tablebrian m. carlson, Sep 13, 2018
  4. 03/12 t0000: update tests for SHA-256brian m. carlson, Sep 13, 2018
  5. 04/12 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Sep 13, 2018
  6. 05/12 t0027: make hash size independentbrian m. carlson, Sep 13, 2018
  7. 06/12 t0064: make hash size independentbrian m. carlson, Sep 13, 2018
  8. 07/12 t1006: make hash size independentbrian m. carlson, Sep 13, 2018
  9. 08/12 t1400: switch hard-coded object ID to variablebrian m. carlson, Sep 13, 2018
  10. 09/12 t1405: make hash size independentbrian m. carlson, Sep 13, 2018
  11. 10/12 t1406: make hash-size independentbrian m. carlson, Sep 13, 2018
  12. 11/12 t1407: make hash size independentbrian m. carlson, Sep 13, 2018
  13. Ævar Arnfjörð BjarmasonSep 13, 2018
  14. 12/12 t5318: use test_oid for HASH_LENbrian m. carlson, Sep 13, 2018
  15. Derrick StoleeSep 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.