git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 07/12] t1006: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Sep 13, 2018, 05:17 UTC
Message-ID
<20180913051742.252276-8-sandals@crustytoothpaste.net>
In-Reply-To
<20180913051742.252276-1-sandals@crustytoothpaste.net>

Compute the size of the tree and commit objects we're creating by checking for the size of an object ID and computing the resulting sizes accordingly.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t1006-cat-file.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
index 7f19d591f2..a7c95bb785 100755
--- a/t/t1006-cat-file.sh
+++ b/t/t1006-cat-file.sh
@@ -140,15 +140,17 @@ test_expect_success '--batch-check without %(rest) considers whole line' '
 	test_cmp expect actual
 '
 
+test_oid_init
+
 tree_sha1=$(git write-tree)
-tree_size=33
+tree_size=$(($(test_oid rawsz) + 13))
 tree_pretty_content="100644 blob $hello_sha1	hello"
 
 run_tests 'tree' $tree_sha1 $tree_size "" "$tree_pretty_content"
 
 commit_message="Initial commit"
 commit_sha1=$(echo_without_newline "$commit_message" | git commit-tree $tree_sha1)
-commit_size=177
+commit_size=$(($(test_oid hexsz) + 137))
 commit_content="tree $tree_sha1
 author $GIT_AUTHOR_NAME <$GIT_AUTHOR_EMAIL> 0000000000 +0000
 committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 0000000000 +0000
Previous: brian m. carlsonNext: brian m. carlson
Message 8 of 15 in “Hash-independent tests (part 3)”
  1. 00/12 Hash-independent tests (part 3)brian m. carlson, Sep 13, 2018
  2. 01/12 t: add test functions to translate hash-related valuesbrian m. carlson, Sep 13, 2018
  3. 02/12 t0000: use hash translation tablebrian m. carlson, Sep 13, 2018
  4. 03/12 t0000: update tests for SHA-256brian m. carlson, Sep 13, 2018
  5. 04/12 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Sep 13, 2018
  6. 05/12 t0027: make hash size independentbrian m. carlson, Sep 13, 2018
  7. 06/12 t0064: make hash size independentbrian m. carlson, Sep 13, 2018
  8. 07/12 t1006: make hash size independentbrian m. carlson, Sep 13, 2018
  9. 08/12 t1400: switch hard-coded object ID to variablebrian m. carlson, Sep 13, 2018
  10. 09/12 t1405: make hash size independentbrian m. carlson, Sep 13, 2018
  11. 10/12 t1406: make hash-size independentbrian m. carlson, Sep 13, 2018
  12. 11/12 t1407: make hash size independentbrian m. carlson, Sep 13, 2018
  13. Ævar Arnfjörð BjarmasonSep 13, 2018
  14. 12/12 t5318: use test_oid for HASH_LENbrian m. carlson, Sep 13, 2018
  15. Derrick StoleeSep 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.