git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 04/12] t0002: abstract away SHA-1 specific constants

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Sep 13, 2018, 05:17 UTC
Message-ID
<20180913051742.252276-5-sandals@crustytoothpaste.net>
In-Reply-To
<20180913051742.252276-1-sandals@crustytoothpaste.net>

Adjust the test so that it computes variables for object IDs instead of using hard-coded hashes.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t0002-gitfile.sh | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh
index 3691023d51..0aa9908ea1 100755
--- a/t/t0002-gitfile.sh
+++ b/t/t0002-gitfile.sh
@@ -92,11 +92,12 @@ test_expect_success 'enter_repo non-strict mode' '
 		mv .git .realgit &&
 		echo "gitdir: .realgit" >.git
 	) &&
+	head=$(git -C enter_repo rev-parse HEAD) &&
 	git ls-remote enter_repo >actual &&
-	cat >expected <<-\EOF &&
-	946e985ab20de757ca5b872b16d64e92ff3803a9	HEAD
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/heads/master
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/tags/foo
+	cat >expected <<-EOF &&
+	$head	HEAD
+	$head	refs/heads/master
+	$head	refs/tags/foo
 	EOF
 	test_cmp expected actual
 '
@@ -106,21 +107,23 @@ test_expect_success 'enter_repo linked checkout' '
 		cd enter_repo &&
 		git worktree add  ../foo refs/tags/foo
 	) &&
+	head=$(git -C enter_repo rev-parse HEAD) &&
 	git ls-remote foo >actual &&
-	cat >expected <<-\EOF &&
-	946e985ab20de757ca5b872b16d64e92ff3803a9	HEAD
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/heads/master
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/tags/foo
+	cat >expected <<-EOF &&
+	$head	HEAD
+	$head	refs/heads/master
+	$head	refs/tags/foo
 	EOF
 	test_cmp expected actual
 '
 
 test_expect_success 'enter_repo strict mode' '
+	head=$(git -C enter_repo rev-parse HEAD) &&
 	git ls-remote --upload-pack="git upload-pack --strict" foo/.git >actual &&
-	cat >expected <<-\EOF &&
-	946e985ab20de757ca5b872b16d64e92ff3803a9	HEAD
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/heads/master
-	946e985ab20de757ca5b872b16d64e92ff3803a9	refs/tags/foo
+	cat >expected <<-EOF &&
+	$head	HEAD
+	$head	refs/heads/master
+	$head	refs/tags/foo
 	EOF
 	test_cmp expected actual
 '
Previous: brian m. carlsonNext: brian m. carlson
Message 5 of 15 in “Hash-independent tests (part 3)”
  1. 00/12 Hash-independent tests (part 3)brian m. carlson, Sep 13, 2018
  2. 01/12 t: add test functions to translate hash-related valuesbrian m. carlson, Sep 13, 2018
  3. 02/12 t0000: use hash translation tablebrian m. carlson, Sep 13, 2018
  4. 03/12 t0000: update tests for SHA-256brian m. carlson, Sep 13, 2018
  5. 04/12 t0002: abstract away SHA-1 specific constantsbrian m. carlson, Sep 13, 2018
  6. 05/12 t0027: make hash size independentbrian m. carlson, Sep 13, 2018
  7. 06/12 t0064: make hash size independentbrian m. carlson, Sep 13, 2018
  8. 07/12 t1006: make hash size independentbrian m. carlson, Sep 13, 2018
  9. 08/12 t1400: switch hard-coded object ID to variablebrian m. carlson, Sep 13, 2018
  10. 09/12 t1405: make hash size independentbrian m. carlson, Sep 13, 2018
  11. 10/12 t1406: make hash-size independentbrian m. carlson, Sep 13, 2018
  12. 11/12 t1407: make hash size independentbrian m. carlson, Sep 13, 2018
  13. Ævar Arnfjörð BjarmasonSep 13, 2018
  14. 12/12 t5318: use test_oid for HASH_LENbrian m. carlson, Sep 13, 2018
  15. Derrick StoleeSep 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.