Re: [PATCH 02/17] odb: introduce "files" source

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 5, 2026, 13:23 UTC
Message-ID: <aamDxB-s7WW0Mq9H@pks.im>
In-Reply-To: <aahbTN_lFx1Jhy7U@denethor>

On Wed, Mar 04, 2026 at 10:57:26AM -0600, Justin Tobler wrote:

Show 15 quoted lines

> On 26/02/23 05:17PM, Patrick Steinhardt wrote:
> > diff --git a/odb/source.h b/odb/source.h
> > index 391d6d1e38..1c34265189 100644
> > --- a/odb/source.h
> > +++ b/odb/source.h
> > @@ -19,11 +21,8 @@ struct odb_source {
> >  	/* Object database that owns this object source. */
> >  	struct object_database *odb;
> >  
> > -	/* Private state for loose objects. */
> > -	struct odb_source_loose *loose;
> > -
> > -	/* Should only be accessed directly by packfile.c and midx.c. */
> 
> Is there any value to keeping this comment around?

I don't think so. With this series it becomes clear that all of the info in the sources become private implementation details, and future patch series will double down on that even further.

Patrick