Re: [PATCH 01/17] odb: split `struct odb_source` into separate header

From: Justin Tobler <jltobler@gmail.com>
Date: Mar 5, 2026, 16:57 UTC
Message-ID: <aam1Tu5wFA58swfi@denethor>
In-Reply-To: <aamDv3M02MKthCPF@pks.im>

On 26/03/05 02:23PM, Patrick Steinhardt wrote:

Show 17 quoted lines

> On Wed, Mar 04, 2026 at 09:55:11AM -0600, Justin Tobler wrote:
> > > diff --git a/odb.h b/odb.h
> > > index 68b8ec2289..e13b5b7c44 100644
> > > --- a/odb.h
> > > +++ b/odb.h
> > > @@ -3,6 +3,7 @@
> > >  
> > >  #include "hashmap.h"
> > >  #include "object.h"
> > > +#include "odb/source.h"
> > 
> > Out of curiousity, since we include the header here, it is transitively
> > included wherever we are using `struct odb_source`. Ideally should we be
> > explicit or would it be best to just rely on this transitively?
> 
> Hum, dunno. I think it's fine to just be pragmatic here and only include
> "odb.h"?

Ya sounds completely fair. I was mostly curious if we intended "odb.h" to server as the entry point here and expected "odb/source.h" to be "internal". This is certainly fine though.

-Justin