Re: [PATCH 01/17] odb: split `struct odb_source` into separate header

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 5, 2026, 13:23 UTC
Message-ID: <aamDv3M02MKthCPF@pks.im>
In-Reply-To: <aahToju3J2qj6lR3@denethor>

On Wed, Mar 04, 2026 at 09:55:11AM -0600, Justin Tobler wrote:

Show 13 quoted lines

> > diff --git a/odb.h b/odb.h
> > index 68b8ec2289..e13b5b7c44 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -3,6 +3,7 @@
> >  
> >  #include "hashmap.h"
> >  #include "object.h"
> > +#include "odb/source.h"
> 
> Out of curiousity, since we include the header here, it is transitively
> included wherever we are using `struct odb_source`. Ideally should we be
> explicit or would it be best to just rely on this transitively?

Hum, dunno. I think it's fine to just be pragmatic here and only include "odb.h"?

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.