Re: [PATCH v3] builtin/remote.c: teach `-v` to list filters for promisor remotes

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: May 8, 2022, 15:33 UTC
Message-ID: <aa9884d5-b69a-bfd2-4235-a30326bd65f6@gmail.com>
In-Reply-To: <pull.1227.v3.git.1651933221216.gitgitgadget@gmail.com>

Hi Abhradeep,

Le 2022-05-07 à 10:20, Abhradeep Chakraborty via GitGitGadget a écrit :

> From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
> 
> `git remote -v` (`--verbose`) lists down the names of remotes along with
> their urls.

small nit: I would capitalize URLs.

Show 13 quoted lines

> It would be beneficial for users to also specify the filter
> types for promisor remotes. Something like this -
> 
> 	origin	remote-url (fetch) [blob:none]
> 	origin	remote-url (push)
> 
> Teach `git remote -v` to also specify the filters for promisor remotes.
> 
> Signed-off-by: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
> ---
>     builtin/remote.c: teach -v to list filters for promisor remotes
>     
>     Fixes #1211 [1]

I don't think this matters much, but if Junio is OK with that, it would be nice to include the reference to the GitGitGadget issue in the commit message itself, though with its full URL, something like:

Closes: https://github.com/gitgitgadget/git/issues/1211

as another trailer before your signed-off-by. By including it in the commit message we allow the issue to be closed automatically when your topic branch is merged to 'master'. By using the full link we make sure that GitHub knows we are targetting that issue specifically, not any other issue or PR in any fork of Git with the same number.

Show 5 quoted lines

>     
>     In the previous version, documentation is updated (describing the
>     proposed change) and url_buf is renamed into remote_info_buf. In this
>     varsion, some more test cases are added and broken indentations are
>     fixed.

Again, small nit to make it easier for reviewers: usually we prefer to see what has changed since the previous version first, and then (if you want, it's not strictly necessary) what changed in the other previous versions. It's not necessary since if we want that info we can refer to the cover letters of the previous iterations directly. And ideally, in bullet points. So something like:

Changes since v2:
- added more test cases
- fixed broken indentations

Changes since v1:
- updated documentation
- renamed url_buf into remote_info_buf

Show 6 quoted lines

>     
>     [1] https://github.com/gitgitgadget/git/issues/1211
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1227%2FAbhra303%2Fpromisor_remote-v3
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1227/Abhra303/promisor_remote-v3
> Pull-Request: https://github.com/gitgitgadget/git/pull/1227

Thanks,

Philippe.