Re: [PATCH v4] builtin/remote.c: teach `-v` to list filters for promisor remotes

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: May 13, 2022, 13:49 UTC
Message-ID: <20220513134946.1581-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <xmqqmtfqd25h.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> Isn't it where we already are with "remote -v", though?  I am not
> sure addition of excess information that may not be universally
> useful is a very welcome change, even with "remote -v -v".  I am not
> worried about showing the "list-object-filter", but I worry about
> managing temptations of future developers to add other stuff.

If future developers come up with some really useful stuff (i.e. universally useful), I think those should be added in the output irrespective of the no of existing info in the output. If the output becomes messy, we should focus on how we can make the output clear may be using tabular format.

Else you can drop the idea and suggest them to introduce a new flag (depending on the situation). If you still have some doubt about my PR i.e. if you can not determine which category my PR belongs to, I can go with adding `show-partial-clone` flag. The downside would be that `remote -v` will not give the full summary in case of partial clone.

If you like the tabular format approach, I am further going to propose a table format -

+---------------+----------------------------------------------+
|  remote name  |          remote info                         |
+---------------+--------+--------+----------------------------+
|               |        | url    | https://blah.com/blah.git  |
|  origin       |        +--------+----------------------------+
|               |        | filter | blob:none                  |
|               | fetch  +--------+----------------------------+
|               |        | .                                   |
|               |        | .     (some important data)         |
|               +--------+--------+----------------------------+
|               |        | url    | https://blah.com/blah.git  |
|               | push   +--------+----------------------------+
|               |        | ... (some important data)           |
+---------------+--------+-------------------------------------+

In this way, user can see the summary of all remotes with visual ease. Of course it is not suitable for scripting. In that case we can use a new flag `--raw` which will let `-v` to provide a space/tab seperated sequence of info (similar to current format).

Let me know if you (as in all) like/dislike my view and give your arguments regarding my proposal.

Thanks :)