Re: [PATCH v3] builtin/remote.c: teach `-v` to list filters for promisor remotes

From: Abhradeep Chakraborty <chakrabortyabhradeep79@gmail.com>
Date: May 9, 2022, 09:13 UTC
Message-ID: <20220509091315.13234-1-chakrabortyabhradeep79@gmail.com>
In-Reply-To: <f15e2673-ddc3-27ff-d31c-7fa32af27ae7@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> wrote:

> I think the tests woud fit better in t5505-remote.sh, since the patch really
> adds a feature to the 'git remote' command.

I think you're right. Thanks!

Show 14 quoted lines

> I found it sligtly awkward to use the future tense here. Maybe just:
>
>     For promisor remotes, also show which filter
>     (`blob:none` etc.) that promisor remote use, wrapped in square brackets.
>
> And technically, it's not really the remote that "uses" the filter, 
> but more the local Git client. So maybe something like this would
> be more accurate and simpler:
>
>     For promisor remotes, also show which filter (`blob:none` etc.)
>     are configured, wrapped in square brackets.
>
> And even then "wrapped in square brackets" *could* be dropped, I 
> think.

Got it. Thanks for the suggestions about both the PR and the patch. Will update it.

Thanks :)