git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] request-pull with diff body itself

From
Cyrill Gorcunov <gorcunov@gmail.com>
Date
Jul 27, 2009, 20:56 UTC
Message-ID
<aa79d98a0907271356l51111uac0884cf148f434f@mail.gmail.com>
In-Reply-To
<7vws5tg8fw.fsf@alter.siamese.dyndns.org>
On 7/28/09, Junio C Hamano <gitster@pobox.com> wrote:
Show 26 quoted lines
> Cyrill Gorcunov <gorcunov@gmail.com> writes:
>
>> Here is rfc in a sake of having ability to produce
>> diff body in small series of changes in request-pull.
>> we could use ">>" here and append diff by hands but
>> adding "-p" option seems more comfortable.
>>
>> Dunno, just a thought.
>
> I think this is a useful thing to add, as I think I've seen some
> request-pull actually made with the patch text, most likely by hand.
>
>>  git shortlog ^$baserev $headrev
>>  git diff -M --stat --summary $merge_base $headrev
>> +
>> +if [ "$usediff" = "yes" ]; then
>> +	echo "---"
>> +	git diff -M -p $merge_base $headrev
>> +fi
>
> You can just use a single "git diff" invocation here,
>
> 	git diff -M --stat --summary $usediff $merge_base $headrev
>
> and set up "$usediff" to be either empty or -p in the option parsing part.
>

yeah, indeed, thanks for the hint Junio! Will post an updated patch in a day or so ( as only get back my laptop back). Or maybe someone could make it faster then me ;)

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “[RFC] request-pull with diff body itself”
  1. Cyrill GorcunovJul 27, 2009
  2. Junio C HamanoJul 27, 2009
  3. Cyrill GorcunovJul 27, 2009
  4. Junio C HamanoJul 27, 2009
  5. Cyrill GorcunovJul 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.