From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Mon, 27 Jul 2009 20:56:10 GMT
Subject: Re: [RFC] request-pull with diff body itself
Message-ID: <aa79d98a0907271356l51111uac0884cf148f434f@mail.gmail.com>
In-Reply-To: <7vws5tg8fw.fsf@alter.siamese.dyndns.org>

On 7/28/09, Junio C Hamano <gitster@pobox.com> wrote:
> Cyrill Gorcunov <gorcunov@gmail.com> writes:
>
>> Here is rfc in a sake of having ability to produce
>> diff body in small series of changes in request-pull.
>> we could use ">>" here and append diff by hands but
>> adding "-p" option seems more comfortable.
>>
>> Dunno, just a thought.
>
> I think this is a useful thing to add, as I think I've seen some
> request-pull actually made with the patch text, most likely by hand.
>
>>  git shortlog ^$baserev $headrev
>>  git diff -M --stat --summary $merge_base $headrev
>> +
>> +if [ "$usediff" = "yes" ]; then
>> +	echo "---"
>> +	git diff -M -p $merge_base $headrev
>> +fi
>
> You can just use a single "git diff" invocation here,
>
> 	git diff -M --stat --summary $usediff $merge_base $headrev
>
> and set up "$usediff" to be either empty or -p in the option parsing part.
>
yeah, indeed, thanks for the hint Junio!
Will post an updated patch in a day or so ( as only get back my laptop
back). Or maybe someone could make it faster then me ;)