Re: [RFC] request-pull with diff body itself

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2009, 20:46 UTC
Message-ID: <7vws5tg8fw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090727195357.GE17942@lenovo>

Cyrill Gorcunov <gorcunov@gmail.com> writes:

Show 6 quoted lines

> Here is rfc in a sake of having ability to produce
> diff body in small series of changes in request-pull.
> we could use ">>" here and append diff by hands but
> adding "-p" option seems more comfortable.
>
> Dunno, just a thought.

I think this is a useful thing to add, as I think I've seen some request-pull actually made with the patch text, most likely by hand.

Show 7 quoted lines

>  git shortlog ^$baserev $headrev
>  git diff -M --stat --summary $merge_base $headrev
> +
> +if [ "$usediff" = "yes" ]; then
> +	echo "---"
> +	git diff -M -p $merge_base $headrev
> +fi

You can just use a single "git diff" invocation here,

	git diff -M --stat --summary $usediff $merge_base $headrev

and set up "$usediff" to be either empty or -p in the option parsing part.