Re: [PATCH 10/17] refs/files: introduce function to perform normal ref checks

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 12, 2026, 08:17 UTC
Message-ID: <aWSuNFd6USWqvLQX@pks.im>
In-Reply-To: <aWJQL3WdZermrAUv@ArchLinux>

On Sat, Jan 10, 2026 at 09:12:15PM +0800, shejialuo wrote:

Show 17 quoted lines

> On Fri, Jan 09, 2026 at 01:39:39PM +0100, Patrick Steinhardt wrote:
> > diff --git a/refs.h b/refs.h
> > index d91fcb2d2f..61c56cca36 100644
> > --- a/refs.h
> > +++ b/refs.h
> > @@ -655,6 +655,14 @@ int check_refname_format(const char *refname, int flags);
> >  
> >  struct fsck_ref_report;
> >  
> > +/*
> > + * Perform generic checks for a specific symref target. This function is
> > + * expected to be called by the ref backends for every symbolic ref.
> > + */
> 
> I think above comment is the same as `refs_fsck_symref`, I think we
> should update to say that we perform generic checks for a ref instead of
> a specific symref target.

Indeed, a classical copy-paste error. Thanks!

Patrick