[PATCH v2 02/17] refs/files: move fsck functions into global scope
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jan 12, 2026, 09:02 UTC
- Message-ID
- <20260112-pks-refs-verify-fixes-v2-2-2e9e453bd6c3@pks.im>
- In-Reply-To
- <20260112-pks-refs-verify-fixes-v2-0-2e9e453bd6c3@pks.im>
When performing consistency checks we pass the functions that perform the verification down the calling stack. This is somewhat unnecessary though, as the set of functions doesn't ever change.
Simplify the code by moving the array into global scope and remove the parameter.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- refs/files-backend.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c index 297739f203..feba3ee58b 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -3890,11 +3890,16 @@ static int files_fsck_refs_name(struct ref_store *ref_store UNUSED, return ret; } +static const files_fsck_refs_fn fsck_refs_fn[]= { + files_fsck_refs_name, + files_fsck_refs_content, + NULL, +}; + static int files_fsck_refs_dir(struct ref_store *ref_store, struct fsck_options *o, const char *refs_check_dir, - struct worktree *wt, - files_fsck_refs_fn *fsck_refs_fn) + struct worktree *wt) { struct strbuf refname = STRBUF_INIT; struct strbuf sb = STRBUF_INIT; @@ -3955,13 +3960,7 @@ static int files_fsck_refs(struct ref_store *ref_store, struct fsck_options *o, struct worktree *wt) { - files_fsck_refs_fn fsck_refs_fn[]= { - files_fsck_refs_name, - files_fsck_refs_content, - NULL, - }; - - return files_fsck_refs_dir(ref_store, o, "refs", wt, fsck_refs_fn); + return files_fsck_refs_dir(ref_store, o, "refs", wt); } static int files_fsck(struct ref_store *ref_store,
-- 2.52.0.590.g1f87b77810.dirty