Re: [PATCH 06/17] refs/files: improve error handling when verifying symrefs

From: shejialuo <shejialuo@gmail.com>
Date: Jan 10, 2026, 12:34 UTC
Message-ID: <aWJHX2te19crFKF4@ArchLinux>
In-Reply-To: <20260109-pks-refs-verify-fixes-v1-6-3587dba18294@pks.im>

On Fri, Jan 09, 2026 at 01:39:35PM +0100, Patrick Steinhardt wrote:

Show 8 quoted lines

> The error handling when verifying symbolic refs is a bit on the wild
> side:
> 
>   - `fsck_report_ref()` can be told to ignore specific errors. If an
>     error has been ignored and a previous check raised an unignored
>     error, then assigning `ret = fsck_report_ref()` will cause us to
>     swallow the previous error.
>

Make sense, I think I haven't thought about this carefully when I wrote the code. I totally ignored the case. Thanks for catching this.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.