Re: [PATCH 10/17] git-compat-util.h: introduce `u32_add()`
On Sat, Dec 06, 2025 at 03:31:28PM -0500, Taylor Blau wrote:
Show 15 quoted lines
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 398e0fac4fa..a7aa5f05fc9 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -670,6 +670,14 @@ static inline int cast_size_t_to_int(size_t a)
> return (int)a;
> }
>
> +static inline uint32_t u32_add(uint32_t a, uint32_t b)
> +{
> + if (unsigned_add_overflows(a, b))
> + die("uint32_t overflow: %"PRIuMAX" + %"PRIuMAX,
> + (uintmax_t)a, (uintmax_t)b);
> + return a + b;
> +}We already use PRIu32 in our codebase, so why is the cast necessary?
Patrick