Re: [PATCH v6 4/7] builtin/repo: introduce structure subcommand

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 22, 2025, 05:01 UTC
Message-ID: <aPhlLbsOFxeOv5KZ@pks.im>
In-Reply-To: <20251021182601.2687284-5-jltobler@gmail.com>

On Tue, Oct 21, 2025 at 01:25:58PM -0500, Justin Tobler wrote: [snip]

> +static int count_references(const char *refname,
> +			    const char *referent UNUSED,
> +			    const struct object_id *oid UNUSED,
> +			    int flags UNUSED, void *cb_data)

Tiniest nit, not worth a reroll: we tend to use these callbacks in singular, as you end up doing the thing for one specific entity.

Other than that this series looks good to me now and is ready to be merged from my point of view. Thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.