Re: [PATCH v4 3/7] clang-format: exclude control macros from SpaceBeforeParens

From: Justin Tobler <jltobler@gmail.com>
Date: Sep 27, 2025, 15:51 UTC
Message-ID: <5g4ysjfqrjltnqr35xh4efhzmqmzpmut44pherfsjzqinfbpmo@6ax5lzob7sox>
In-Reply-To: <xmqqv7l39a5c.fsf@gitster.g>

On 25/09/27 08:40AM, Junio C Hamano wrote:

Show 16 quoted lines

> Justin Tobler <jltobler@gmail.com> writes:
> 
> > The formatter currently suggests adding a space between a control macro
> > and parentheses. In the Git project, this is not typically expected. Set
> > `SpaceBeforeParens` to `ControlStatementsExceptControlMacros`
> > accordingly.
> >
> > Helped-by: Karthik Nayak <karthik.188@gmail.com>
> > Signed-off-by: Justin Tobler <jltobler@gmail.com>
> > ---
> >  .clang-format | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> While this may be a welcome addition, I somehow do not think it
> belongs as [3/7] to this series, whose theme is about "git repo
> stats".

That's completely fair. I noticed the formatter flagged this issue while working on this series, but I was also on the fence as to whether it should be submitted separately.

> Perhaps make it a separate topic and have it graduate sooner?

I'll send this patch as a separate topic and can send another version of this series without this patch.

Thanks, -Justin