Re: [PATCH 03/13] refs: refactor reference status flags
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 8, 2025, 13:44 UTC
- Message-ID
- <aOZqt7s3wWtIK8ev@pks.im>
- In-Reply-To
- <CAOLa=ZTL7kY6_2AqjYJGrjnKgwWVBbjrtgha-dBR-ijL7C87tg@mail.gmail.com>
On Tue, Oct 07, 2025 at 07:27:55AM -0700, Karthik Nayak wrote:
Show 17 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/refs.h b/refs.h
> > index 2b24a3d997..8f484e2ffc 100644
> > --- a/refs.h
> > +++ b/refs.h
> > @@ -333,27 +333,28 @@ struct ref_transaction;
> > * stored in ref_iterator::flags. Other bits are for internal use
> > * only:
> > */
> > +enum reference_status {
> > + /* Reference is a symbolic reference. */
> > + REF_ISSYMREF = (1 << 0),
> >
>
> Nit: It would also be nice to rename these flags to
> 'REFERENCE_STATUS_*', since that seems to be the pattern we generally
> follow. Doesn't have to be in your series though :)Yeah, let's rather punt this to another series. There's hundreds of uses of these, and I feel like the series is already quite big.
Patrick