Re: [PATCH 02/13] refs: introduce `.ref` field for the base iterator

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 7, 2025, 21:57 UTC
Message-ID: <aOWM48xFTql8OkNR@nand.local>
In-Reply-To: <20251007-b4-pks-ref-filter-skip-parsing-objects-v1-2-916cc7c6886b@pks.im>

On Tue, Oct 07, 2025 at 12:58:39PM +0200, Patrick Steinhardt wrote:

Show 10 quoted lines

> ---
>  refs.c                  |  8 ++++----
>  refs/debug.c            |  8 +++-----
>  refs/files-backend.c    | 47 +++++++++++++++++++++--------------------------
>  refs/iterator.c         | 39 ++++++++++++---------------------------
>  refs/packed-backend.c   | 46 +++++++++++++++++++++++-----------------------
>  refs/ref-cache.c        | 10 +++++-----
>  refs/refs-internal.h    |  5 +----
>  refs/reftable-backend.c | 12 ++++++------
>  8 files changed, 75 insertions(+), 100 deletions(-)

Besides the couple of typos that Justin and Karthik mentioned in their respective replies to this message, this change makes sense and looks good to me.

Thanks, Taylor