Re: [PATCH v2 4/9] docs: improve ambiguous areas of pack format documentation
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 3, 2025, 21:06 UTC
- Message-ID
- <aOA6z-kFCd78XtxX@fruit.crustytoothpaste.net>
- In-Reply-To
- <xmqqv7kvud5o.fsf@gitster.g>
On 2025-10-03 at 17:07:47, Junio C Hamano wrote:
Show 15 quoted lines
> "brian m. carlson" <sandals@crustytoothpaste.net> writes: > > > +=== Object encoding > > + > > +Unlike loose objects, packed objects do not have a prefix containing the type, > > +size, and a NUL byte. These are not necessary because they can be determined by > > +the n-byte type and length that prefixes the data and so they are omitted from > > +the compressed and deltified data. > > + > > +The computation of the object ID still uses this prefix, however. > > "however" -> "by reconstructing it from the type/length data as > needed"? > > Other than that, the new text reads very well.
I've already squashed in a very similar change. I'll wait to see if Patrick or anyone else has more comments and then send v3.
-- brian m. carlson (they/them) Toronto, Ontario, CA