git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] builtin/reflog: respect user config in "write" subcommand

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 1, 2025, 07:37 UTC
Message-ID
<aNzaKAuuzzX1xg6I@pks.im>
In-Reply-To
<20250930195320.23825-1-git@lohmann.sh>
On Tue, Sep 30, 2025 at 09:53:20PM +0200, Michael Lohmann wrote:
Show 12 quoted lines
> The reflog write recognizes only GIT_COMMITTER_NAME and
> GIT_COMMITTER_EMAIL environment variables, but forgot to honor the
> user.name and user.email configuration variables, due to lack of
> repo_config() call to grab these values from the configuration files.
> 
> The test suite sets these variables, so this behavior was unnoticed.
> 
> Ensure that the reflog write also uses the values of user.name and
> user.email if set in the Git configuration.
> 
> Co-authored-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Michael Lohmann <git@lohmann.sh>
Thanks, this version looks good to me!
Patrick
Previous: Michael LohmannNext: Junio C Hamano
Message 8 of 9 in “git reflog write does not pick up user.name and user.email from config”
  1. MichaelSep 29, 2025
  2. Patrick SteinhardtSep 29, 2025
  3. builtin/reflog: respect user config in "write" subcommandgitmlko@not-evil.de, Sep 30, 2025
  4. Patrick SteinhardtSep 30, 2025
  5. builtin/reflog: respect user config in "write" subcommandgit@lohmann.sh, Sep 30, 2025
  6. Junio C HamanoSep 30, 2025
  7. builtin/reflog: respect user config in "write" subcommandMichael Lohmann, Sep 30, 2025
  8. Patrick SteinhardtOct 1, 2025
  9. Junio C HamanoOct 1, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.