From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 01 Oct 2025 07:37:12 GMT
Subject: Re: [PATCH v3] builtin/reflog: respect user config in "write" subcommand
Message-ID: <aNzaKAuuzzX1xg6I@pks.im>
In-Reply-To: <20250930195320.23825-1-git@lohmann.sh>

On Tue, Sep 30, 2025 at 09:53:20PM +0200, Michael Lohmann wrote:
> The reflog write recognizes only GIT_COMMITTER_NAME and
> GIT_COMMITTER_EMAIL environment variables, but forgot to honor the
> user.name and user.email configuration variables, due to lack of
> repo_config() call to grab these values from the configuration files.
> 
> The test suite sets these variables, so this behavior was unnoticed.
> 
> Ensure that the reflog write also uses the values of user.name and
> user.email if set in the Git configuration.
> 
> Co-authored-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Michael Lohmann <git@lohmann.sh>

Thanks, this version looks good to me!

Patrick