Re: [PATCH v3] builtin/reflog: respect user config in "write" subcommand

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2025, 16:50 UTC
Message-ID: <xmqqcy7636s7.fsf@gitster.g>
In-Reply-To: <aNzaKAuuzzX1xg6I@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 15 quoted lines

> On Tue, Sep 30, 2025 at 09:53:20PM +0200, Michael Lohmann wrote:
>> The reflog write recognizes only GIT_COMMITTER_NAME and
>> GIT_COMMITTER_EMAIL environment variables, but forgot to honor the
>> user.name and user.email configuration variables, due to lack of
>> repo_config() call to grab these values from the configuration files.
>> 
>> The test suite sets these variables, so this behavior was unnoticed.
>> 
>> Ensure that the reflog write also uses the values of user.name and
>> user.email if set in the Git configuration.
>> 
>> Co-authored-by: Patrick Steinhardt <ps@pks.im>
>> Signed-off-by: Michael Lohmann <git@lohmann.sh>
>
> Thanks, this version looks good to me!

Yup.  Will apply on top of the ps/reflog-migrate-fixes topic.

I didn't realize "reflog write" was so new ;-)

Thanks.