Re: [PATCH 2/9] commit-graph: stop using signed integers to count bloom filters

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Aug 4, 2025, 09:13 UTC
Message-ID: <aJB5uKFdGybf-IbN@ugly>
In-Reply-To: <20250804-b4-pks-commit-graph-wo-the-repository-v1-2-850d626eb2e8@pks.im>

On Mon, Aug 04, 2025 at 10:17:18AM +0200, Patrick Steinhardt wrote:

Show 7 quoted lines

>When writing a new commit graph we have a couple of counters that
>provide statistics around what kind of bloom filters we have or have not
>written. These counters naturally count from zero and are only ever
>incremented, but they use a signed integer as type regardless.
>
>Refactor those fields to be of type `size_t` instead.
>

mind elaborating on that choice? it feels like abuse at the semantic level, and it increases the data size on lp64 platforms. is it even compatible with OPT_UNSIGNED (in later commits)? that would be unexpected ...

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.