Re: [PATCH 2/9] commit-graph: stop using signed integers to count bloom filters

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 4, 2025, 21:42 UTC
Message-ID: <aJEpU0VUav17beOt@nand.local>
In-Reply-To: <20250804-b4-pks-commit-graph-wo-the-repository-v1-2-850d626eb2e8@pks.im>

On Mon, Aug 04, 2025 at 10:17:18AM +0200, Patrick Steinhardt wrote:

> When writing a new commit graph we have a couple of counters that
> provide statistics around what kind of bloom filters we have or have not

s/bloom/Bloom

> written. These counters naturally count from zero and are only ever
> incremented, but they use a signed integer as type regardless.
>
> Refactor those fields to be of type `size_t` instead.

I have some thoughts about this, but I see that others do as well, so I'll refrain from sharing them here and instead join the discussion in the sub-thread.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.