From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Mon, 04 Aug 2025 09:13:28 GMT
Subject: Re: [PATCH 2/9] commit-graph: stop using signed integers to count bloom filters
Message-ID: <aJB5uKFdGybf-IbN@ugly>
In-Reply-To: <20250804-b4-pks-commit-graph-wo-the-repository-v1-2-850d626eb2e8@pks.im>

On Mon, Aug 04, 2025 at 10:17:18AM +0200, Patrick Steinhardt wrote:
>When writing a new commit graph we have a couple of counters that
>provide statistics around what kind of bloom filters we have or have not
>written. These counters naturally count from zero and are only ever
>incremented, but they use a signed integer as type regardless.
>
>Refactor those fields to be of type `size_t` instead.
>
mind elaborating on that choice?
it feels like abuse at the semantic level, and it increases the data 
size on lp64 platforms. is it even compatible with OPT_UNSIGNED (in 
later commits)? that would be unexpected ...