Re: [PATCH v2 1/5] MyFirstContribution: add "Anatomy of a Patch Series" section
- From
Philip Oakley <philipoakley@iee.email>
- Date
- May 12, 2022, 12:11 UTC
- Message-ID
- <a901e47d-79cd-8d23-8c6c-de6299716eca@iee.email>
- In-Reply-To
- <59af7e5e5ad84103b39ac9511791eb06b88df3c6.1652233654.git.gitgitgadget@gmail.com>
On 11/05/2022 02:47, Philippe Blain via GitGitGadget wrote:
Show 10 quoted lines
> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt > index 63a2ef54493..22848f84bec 100644 > --- a/Documentation/MyFirstContribution.txt > +++ b/Documentation/MyFirstContribution.txt > @@ -710,13 +710,61 @@ dependencies. `prove` also makes the output nicer. > Go ahead and commit this change, as well. > > [[ready-to-share]] > -== Getting Ready to Share > +== Getting Ready to Share: Anatomy of a Patch Series
Shouldn't the title also include the magic word 'Contribution'? Otherwise the change below may look inconsistent.
> You may have noticed already that the Git project performs its code reviews via > emailed patches, which are then applied by the maintainer when they are ready > -and approved by the community. The Git project does not accept patches from > +and approved by the community. The Git project does not accept contributions from
-- Philip