git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] MyFirstContribution: move cover letter description to a separate file

From
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 27, 2022, 19:04 UTC
Message-ID
<7e84d5b286de9dddf28ef1c8f38c7d7c28e266f0.1651086288.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1226.git.1651086288.gitgitgadget@gmail.com>
From: Philippe Blain <levraiphilippeblain@gmail.com>

In a subsequent commit we want to reuse the explanation of the purpose of The cover letter form the "Sending Patches with git send-email" section in the "Sending Patches via GitGitGadget" section.

To avoid text duplication, move this explanation to a separate file and include it in MyFirstContribution.txt.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 .../MyFirstContribution-coverletter.txt       | 18 ++++++++++++++++
 Documentation/MyFirstContribution.txt         | 21 ++-----------------
 2 files changed, 20 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/MyFirstContribution-coverletter.txt
diff --git a/Documentation/MyFirstContribution-coverletter.txt b/Documentation/MyFirstContribution-coverletter.txt
new file mode 100644
index 00000000000..b9e1e10427a
--- /dev/null
+++ b/Documentation/MyFirstContribution-coverletter.txt
@@ -0,0 +1,18 @@
+This is an important component of change submission as it explains to the
+community from a high level what you're trying to do, and why, in a way that's
+more apparent than just looking at your diff. Be sure to explain anything your
+diff doesn't make clear on its own.
+
+Here's an example body for `psuh`:
+
+----
+Our internal metrics indicate widespread interest in the command
+git-psuh - that is, many users are trying to use it, but finding it is
+unavailable, using some unknown workaround instead.
+
+The following handful of patches add the psuh command and implement some
+handy features on top of it.
+
+This patchset is part of the MyFirstContribution tutorial and should not
+be merged.
+----
diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
index 63a2ef54493..681bbefe9cd 100644
--- a/Documentation/MyFirstContribution.txt
+++ b/Documentation/MyFirstContribution.txt
@@ -976,25 +976,8 @@ filter their email for this type of flag.
 You'll need to add some extra parameters when you invoke `git send-email` to add
 the cover letter.
 
-Next you'll have to fill out the body of your cover letter. This is an important
-component of change submission as it explains to the community from a high level
-what you're trying to do, and why, in a way that's more apparent than just
-looking at your diff. Be sure to explain anything your diff doesn't make clear
-on its own.
-
-Here's an example body for `psuh`:
-
-----
-Our internal metrics indicate widespread interest in the command
-git-psuh - that is, many users are trying to use it, but finding it is
-unavailable, using some unknown workaround instead.
-
-The following handful of patches add the psuh command and implement some
-handy features on top of it.
-
-This patchset is part of the MyFirstContribution tutorial and should not
-be merged.
-----
+Next you'll have to fill out the body of your cover letter.
+include::MyFirstContribution-coverletter.txt[]
 
 The template created by `git format-patch --cover-letter` includes a diffstat.
 This gives reviewers a summary of what they're in for when reviewing your topic.
-- 
gitgitgadget
Previous: Philippe BlainNext: Eric Sunshine
Message 11 of 43 in “Improve MyFirstContribution's GitGitGadget section”
  1. 0/3 Improve MyFirstContribution's GitGitGadget sectionPhilippe Blain via GitGitGadget, Apr 27, 2022
  2. 3/3 MyFirstContribution: drop PR description for GGG single-patch contributionsPhilippe Blain via GitGitGadget, Apr 27, 2022
  3. Junio C HamanoApr 27, 2022
  4. Philippe BlainApr 28, 2022
  5. Junio C HamanoApr 28, 2022
  6. 2/3 MyFirstContribution: also explain cover letter in GitGitGadget sectionPhilippe Blain via GitGitGadget, Apr 27, 2022
  7. Victoria DyeApr 27, 2022
  8. Philippe BlainApr 28, 2022
  9. Victoria DyeApr 29, 2022
  10. Philippe BlainMay 10, 2022
  11. 1/3 MyFirstContribution: move cover letter description to a separate filePhilippe Blain via GitGitGadget, Apr 27, 2022
  12. Eric SunshineApr 27, 2022
  13. Philippe BlainApr 27, 2022
  14. Junio C HamanoApr 27, 2022
  15. Philippe BlainApr 28, 2022
  16. 0/5 Improve MyFirstContribution's GitGitGadget sectionPhilippe Blain via GitGitGadget, May 11, 2022
  17. 1/5 MyFirstContribution: add "Anatomy of a Patch Series" sectionPhilippe Blain via GitGitGadget, May 11, 2022
  18. Bagas SanjayaMay 11, 2022
  19. Junio C HamanoMay 11, 2022
  20. Philippe BlainMay 11, 2022
  21. Junio C HamanoMay 11, 2022
  22. Philippe BlainMay 12, 2022
  23. Philip OakleyMay 12, 2022
  24. Philippe BlainMay 12, 2022
  25. 2/5 MyFirstContribution: add standalone section on cover letterPhilippe Blain via GitGitGadget, May 11, 2022
  26. Junio C HamanoMay 11, 2022
  27. Philippe BlainMay 11, 2022
  28. 3/5 MyFirstContribution: reference "The cover letter" in "Preparing Email"Philippe Blain via GitGitGadget, May 11, 2022
  29. 5/5 MyFirstContribution: drop PR description for GGG single-patch contributionsPhilippe Blain via GitGitGadget, May 11, 2022
  30. 4/5 MyFirstContribution: reference "The cover letter" in GitGitGadget sectionPhilippe Blain via GitGitGadget, May 11, 2022
  31. Junio C HamanoMay 11, 2022
  32. Victoria DyeMay 11, 2022
  33. 0/5 Improve MyFirstContribution's GitGitGadget sectionPhilippe Blain via GitGitGadget, May 12, 2022
  34. 3/5 MyFirstContribution: reference "The cover letter" in "Preparing Email"Philippe Blain via GitGitGadget, May 12, 2022
  35. 1/5 MyFirstContribution: add "Anatomy of a Patch Series" sectionPhilippe Blain via GitGitGadget, May 12, 2022
  36. 5/5 MyFirstContribution: drop PR description for GGG single-patch contributionsPhilippe Blain via GitGitGadget, May 12, 2022
  37. 4/5 MyFirstContribution: reference "The cover letter" in GitGitGadget sectionPhilippe Blain via GitGitGadget, May 12, 2022
  38. 2/5 MyFirstContribution: add standalone section on cover letterPhilippe Blain via GitGitGadget, May 12, 2022
  39. Junio C HamanoMay 19, 2022
  40. Philippe BlainMay 21, 2022
  41. Junio C HamanoMay 22, 2022
  42. Philippe BlainMay 24, 2022
  43. Junio C HamanoMay 24, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.