Re: [msysGit] [PATCH 2/3] git-gui: fix PATH environment for mingw development environment

From: Pat Thoyts <patthoyts@googlemail.com>
Date: Feb 28, 2010, 00:57 UTC
Message-ID: <a5b261831002271657n41ab0f37sc0af50d3a768bfd1@mail.gmail.com>
In-Reply-To: <20100227204741.GC33000@book.hvoigt.net>

On 27 February 2010 20:47, Heiko Voigt <hvoigt@hvoigt.net> wrote:

Show 36 quoted lines

> When creating a desktop shortcut from the gui the shortcut directly
> starts wish with the git-gui script. In the msysgit development
> environment some dll's reside in the mingw/bin directory which causes
> that git can not start because libiconv2.dll is not found.
>
> When using such a link the error is even more cryptic stating:
> "child killed: unknown signal"
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
> I am not sure whether this is the most elegant solution, but making this
> work would definitely ease the development workflow.
>
>  git-gui/windows/git-gui.sh |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/git-gui/windows/git-gui.sh b/git-gui/windows/git-gui.sh
> index 66bbb2f..b1845c5 100644
> --- a/git-gui/windows/git-gui.sh
> +++ b/git-gui/windows/git-gui.sh
> @@ -13,10 +13,11 @@ if { $argc >=2 && [lindex $argv 0] == "--working-dir" } {
>        incr argc -2
>  }
>
> -set bindir [file dirname \
> +set basedir [file dirname \
>             [file dirname \
>              [file dirname [info script]]]]
> -set bindir [file join $bindir bin]
> +set bindir [file join $basedir bin]
> +set bindir "$bindir;[file join $basedir mingw bin]"
>  regsub -all ";" $bindir "\\;" bindir
>  set env(PATH) "$bindir;$env(PATH)"
>  unset bindir
> --
> 1.7.0.m5.rc3.5.g38df2

I have not tried to test this - I use cmd shell all the time so I always run this using 'git gui' which runs the git.cmd script in ProgramFiles\Git\cmd or in the development environment in msysgit\cmd\. It makes me wonder if the Windows shortcut shouldn;t be pointing to the cmd script rather than to a tcl script like this as the cmd script does some quite extensive environment setup. It assigns HOME if it is not set, extends the PATH to include the git installation locations, sets the PLINK_PROTOCOL and the codepages for the console. Probably only the PATH and HOME fixups are necessary for git-gui and in fact tcl's configuration of "~" in the path as HOME probably deals with that too. This is just for the development setup right? An installation of msysGit doesn't have a mingw\bin directory. Pat Thoyts